FIX: Add option on rpc server for accepting multiple services #1074
+15
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (36.36%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1074 +/- ##
==========================================
- Coverage 87.34% 79.20% -8.14%
==========================================
Files 36 40 +4
Lines 2362 2751 +389
==========================================
+ Hits 2063 2179 +116
- Misses 299 572 +273 |
koubaa
reviewed
Jan 30, 2025
| [self._install_function(method) for method in methods] | ||
|
|
||
| def _install_classes(self, impl): |
There was a problem hiding this comment.
imo - class can be either a single class or a list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way user can call their own servicemethods with DefaultServiceMethods for a custom server